[LTP] [PATCH v4 2/2] Make checks for termio flags more strict
Marius Kittler
mkittler@suse.de
Mon Sep 18 10:55:02 CEST 2023
The checks for termio flags can actually use a `!=` check to
also fail when any unexpected flags are present.
Signed-off-by: Marius Kittler <mkittler@suse.de>
---
testcases/kernel/syscalls/ioctl/ioctl02.c | 13 +++++--------
1 file changed, 5 insertions(+), 8 deletions(-)
diff --git a/testcases/kernel/syscalls/ioctl/ioctl02.c b/testcases/kernel/syscalls/ioctl/ioctl02.c
index e5510124c..7b73c60d2 100644
--- a/testcases/kernel/syscalls/ioctl/ioctl02.c
+++ b/testcases/kernel/syscalls/ioctl/ioctl02.c
@@ -189,24 +189,21 @@ static int chk_tty_parms(void)
}
}
- if (!
- (termio.c_lflag
- && (ISIG | ICANON | XCASE | ECHO | ECHOE | NOFLSH))) {
+ if (termio.c_lflag != (ISIG | ICANON | XCASE | ECHO | ECHOE
+ | NOFLSH)) {
tst_res(TINFO, "lflag has incorrect value. %o",
termio.c_lflag);
flag++;
}
- if (!
- (termio.c_iflag
- && (BRKINT | IGNPAR | INPCK | ISTRIP | ICRNL | IUCLC | IXON | IXANY
- | IXOFF))) {
+ if (termio.c_iflag != (BRKINT | IGNPAR | INPCK | ISTRIP
+ | ICRNL | IUCLC | IXON | IXANY | IXOFF)) {
tst_res(TINFO, "iflag has incorrect value. %o",
termio.c_iflag);
flag++;
}
- if (!(termio.c_oflag && (OPOST | OLCUC | ONLCR | ONOCR))) {
+ if (termio.c_oflag != (OPOST | OLCUC | ONLCR | ONOCR)) {
tst_res(TINFO, "oflag has incorrect value. %o",
termio.c_oflag);
flag++;
--
2.42.0
More information about the ltp
mailing list