[LTP] [PATCH v4 1/2] Refactor ioctl02.c to use the new test API
Petr Vorel
pvorel@suse.cz
Mon Sep 18 15:14:35 CEST 2023
> Hi Marius,
> Could you please fix formatting and other common errors?
> $ make check-getxattr01
> CHECK testcases/kernel/syscalls/getxattr/getxattr01.c
> getxattr01.c:81: WARNING: Missing a blank line after declarations
> getxattr01.c:83: WARNING: Missing a blank line after declarations
> getxattr01.c:106: WARNING: braces {} are not necessary for single statement
> blocks
> getxattr01.c:127: WARNING: Missing a blank line after declarations
> make: [../../../../include/mk/rules.mk:56: check-getxattr01] Error 1 (ignored)
> getxattr01.c:50:3: warning: Symbol 'tcases' has no prototype or library ('tst_')
> prefix. Should it be static?
> Also (very nit), backticks (`) are good for github formatting, but they look
> strange in git commits. Could you avoid using it in git subject?
> (e.g. "Port `getxattr01.c` to new test API" should be "Port getxattr01.c to
> new test API").
Hm, this was meant to be posted to getxattr01 v2 patch, posting it there.
https://patchwork.ozlabs.org/project/ltp/patch/20230915135752.7275-1-mkittler@suse.de/
Kind regards,
Petr
> > Related issue: https://github.com/linux-test-project/ltp/issues/583
> We use:
> Fixes: #583
> Kind regards,
> Petr
More information about the ltp
mailing list