[LTP] [PATCH v1] Port getxattr03.c to new test API

Wei Gao wegao@suse.com
Fri Sep 22 14:20:38 CEST 2023


On Fri, Sep 22, 2023 at 11:23:47AM +0200, Marius Kittler wrote:
> Am Freitag, 22. September 2023, 02:00:32 CEST schrieb Wei Gao:
> > > #ifdef HAVE_SYS_XATTR_H
> > 
> > Normally i saw this kind of ifdef in include/lapi/xattr.h
> > I suppose we need create include/lapi/xattr.h?
> 
> No, we don't need that header here. This macro is actually defined in `config.h` 
> which also makes sense as it is generated at configuration time. Note that also 
> all builds (including musl) are passing with this change, see
> https://github.com/Martchus/ltp/actions/runs/6259530698.
Maybe some misunderstanding, i mean put ifdef logic into include/lapi/xattr.h instead 
of define HAVE_SYS_XATTR_H, since i saw ifdef logic for judge exist of xxx.h normally 
handled in include/lapi/xxx.h.
> 
> 
> 
> 
> -- 
> Mailing list info: https://lists.linux.it/listinfo/ltp


More information about the ltp mailing list