[LTP] [RFC][PATCH 2/2] vma05.sh: Add check for core file presence

Petr Vorel pvorel@suse.cz
Tue Sep 26 17:21:55 CEST 2023


> Hi!
> > Maybe this sanity check is useless. WDYT?

> I guess that it does not harm.

Thanks for your review!

> >  testcases/kernel/mem/vma/vma05.sh | 2 ++
> >  1 file changed, 2 insertions(+)

> > diff --git a/testcases/kernel/mem/vma/vma05.sh b/testcases/kernel/mem/vma/vma05.sh
> > index c9e4becdb..30b1d689a 100755
> > --- a/testcases/kernel/mem/vma/vma05.sh
> > +++ b/testcases/kernel/mem/vma/vma05.sh
> > @@ -54,6 +54,8 @@ vma_report_check()

> >  	rm -rf core*
> >  	{ vma05_vdso; } > /dev/null 2>&1
> > +	[ -f core ] || tst_brk TCONF "missing core file"

> TCONF or TBROK that is the question.

I guess TBROK is better in this case. I wonder myself why I type TCONF.
If nobody complains, I'll merge this with TBROK and your ack.

Kind regards,
Petr


More information about the ltp mailing list