[LTP] [PATCH] mremap06: fallocate is not supported on nfsv3
Cyril Hrubis
chrubis@suse.cz
Wed Apr 10 11:30:23 CEST 2024
Hi!
> > > > - if (ret == -1)
> > > > + if (ret != 0) {
> > > > + if (errno == EOPNOTSUPP || errno == ENOSYS) {
> > > > + tst_brk(TCONF,
> > > > + "fallocate system call is not implemented");
> > > > + }
> > > > tst_brk(TBROK, "fallocate() failed");
> > > > + return;
>
> I suggest to merge this now, without return (it can be removed before merge).
> Reviewed-by: Petr Vorel <pvorel@suse.cz>
Shouldn't we limit this only to nfs, to make sure that fallocate() is
not accidentally disabled on other filesystems? At least that what I
suggested when I replied to the patch.
--
Cyril Hrubis
chrubis@suse.cz
More information about the ltp
mailing list