[LTP] [PATCH] pkey01: Adding test for PKEY_DISABLE_EXECUTE

Li Wang liwang@redhat.com
Thu Aug 8 12:20:50 CEST 2024


Hi Petr,

Petr Vorel <pvorel@suse.cz> wrote:


> > +     if (!execute_supported && (tc->access_rights ==
> PKEY_DISABLE_EXECUTE))
> > +             tst_brk(TCONF, "skip PKEY_DISABLE_EXECUTE test");
> NOTE due to possible tst_brk() it'd be good to keep PKEY_DISABLE_EXECUTE
> as a
> last test. Not sure if it's worth to add a comment (or replace with
> tst_res()
> and return).
>

Or, we can use 'tst_res + return' which is similar to tst_hugepages missing
way.

The rest comments all look good.


-- 
Regards,
Li Wang


More information about the ltp mailing list