[LTP] [PATCH v5 3/6] Disable kernel version check in landlock tests

[Andrea Cervesato]

Hi Meckael,

On 8/9/24 16:36, Mickaël Salaün wrote:
> On Thu, Aug 08, 2024 at 11:58:24AM +0200, Petr Vorel wrote:
>> is is really helpful when landlock support has
>>> been backported into old kernels.
>> Great, I'm glad you removed it from all landlock tests. It really did not make
>> sense to guard correct version with 3 guards (kernel version, kernel config and
>> ABI). Could you please remove also CONFIG_SECURITY_LANDLOCK=y, because you
>> check EOPNOTSUPP in verify_landlock_is_enabled().
>>
>> Anyway, feel free to merge these first 3 patches (ideally remove also
>> CONFIG_SECURITY_LANDLOCK=y before merge).
> My understanding is that LTP only tests supported features to make sure
> they work as expected, if enabled.  Is it correct?
Yes, landlock in particular can be a backported feature, so we need to 
remove CONFIG flags and kernel version, raising an error just in case we 
have ENOSYS.
> I'm then wondering what is the purpose of needs_kconfigs.  If there is
> no "needed" config, does that means that Landlock tests will always run
> and detect at run time if tests are skipped or not?  If yes, it looks
> good to me.
>
> Andrea's commit to remove needs_kconfig:
> https://github.com/linux-test-project/ltp/commit/e7ebc637d0d99295490adf57660a3b3a177d65d3
>
> Is there an online dashboard to see some tested kernels?
@Petr Vorel
>
>> Reviewed-by: Petr Vorel <pvorel@suse.cz>
>>
>> Kind regards,
>> Petr
>>
>> -- 
>> Mailing list info: https://lists.linux.it/listinfo/ltp
Regards,
Andrea