Hi! > +static void create_keyring(const int operation) > +{ > + TEST(keyctl(operation, NULL, 0, 0, 0)); > + if (TST_RET == -1) > + tst_brk(TERRNO | TBROK, "keyctl() failed"); > +} This looks like we should add SAFE_KEYCTL() instead... Other than that the rest of the code looks good. -- Cyril Hrubis chrubis@suse.cz