[LTP] [PATCH v3 1/2] nfs_lib.sh: Add support for extra NFS mount options

[Martin Doucha]

Hi,

On 05. 12. 24 11:34, Petr Vorel wrote:
> Hi Martin,
> 
> ...
>> +		nfs_opts="-o proto=$type,vers=$i"
>> +
>> +		if [ ! -z "$NFS_MOUNT_OPTS" ]; then
> 
> We have -n for non-null string. Even just [ "$NFS_MOUNT_OPTS" ] would work,
> but -n is more obvious. I can change it before merge:
> 
> 		if [ -n "$NFS_MOUNT_OPTS" ]; then

Please do, thanks.

> Reviewed-by: Petr Vorel <pvorel@suse.cz>
> 
> Kind regards,
> Petr
> 
>> +			nfs_opts="$nfs_opts,$NFS_MOUNT_OPTS"
>> +		fi
>> +
>>   		tst_res TINFO "Mounting $local_dir"
>> -		nfs_mount "$local_dir" "$remote_dir" "-o proto=$type,vers=$i"
>> +		nfs_mount "$local_dir" "$remote_dir" "$nfs_opts"


-- 
Martin Doucha   mdoucha@suse.cz
SW Quality Engineer
SUSE LINUX, s.r.o.
CORSO IIa
Krizikova 148/34
186 00 Prague 8
Czech Republic