[LTP] [PATCH v3 2/2] Add test for data integrity over NFS

Martin Doucha mdoucha@suse.cz
Thu Dec 5 13:25:01 CET 2024


Hi,

On 05. 12. 24 12:10, Petr Vorel wrote:
>> +
>> +nfs10_setup()
>> +{
>> +	local bsize=$(stat -f -c %s .)
>> +
>> +	bsize=$(( $bsize < 1024 ? 1024 : $bsize ))
> 
> nit: this would work if stat is not installed (minimal systems) or fails for
> some reason:
> 
> if [ -z "$bsize" ] || [ "$bsize" -lt 1024 ]; then
> 	bsize=1024
> fi
> 
> If you agree, I can change it during merge.
> Otherwise LGTM.

Please do, thank you.

-- 
Martin Doucha   mdoucha@suse.cz
SW Quality Engineer
SUSE LINUX, s.r.o.
CORSO IIa
Krizikova 148/34
186 00 Prague 8
Czech Republic


More information about the ltp mailing list