[LTP] [PATCH 2/2] Add madvise12 test
Petr Vorel
pvorel@suse.cz
Wed Dec 11 10:55:56 CET 2024
Hi Lorenzo, Andrea,
> On Wed, Dec 11, 2024 at 01:30:48AM +0100, Petr Vorel wrote:
> > Hi Andrea,
> > [ I dared to Cc Lorenzo, the author of the kernel implementation ]
> I'm not that scary am I? :)))
> Feel free to cc- me on anything relating to this even if obviously in the
> LTP project happy to be included! :)
Thank you, we really appreciate that!
> > > Verify that MADV_GUARD_INSTALL is causing SIGSEGV when someone is
> > > trying to access memory advised with it.
> > Test LGTM, thanks for covering a new kernel feature.
> All good, looks fine to me, though might be worth expanding over time, we
> have some self tests in the kernel for this, see
> tools/testing/selftests/mm/guard-pages.c.
Great! Noted at the ticket.
> But it's nice to have a basic LTP regression test to assert the fundamental
> thing is working as it should, and also nice that you implement it from
> your perspective rather than mine, where I am obviously rather influenced
> by implementation details.
> Also note I submitted man pages for the change, you can pull it from [0]
> and view it via:
> $ man --manpath=. 2 madvise
> [0]:git://git.kernel.org/pub/scm/docs/man-pages/man-pages.git
+1
Kind regards,
Petr
> Hopefully these will get distributed around soon!
> Thanks for doing this for my feature, much appreciated overall!
> Cheers, Lorenzo
...
More information about the ltp
mailing list