Hi! Generally looks good now. It would be better if the newly added function had a proper documentation comment as Peter pointed out. So as long as you fix the minor issues pointed you by Peter you can add my: Reviewed-by: Cyril Hrubis <chrubis@suse.cz> -- Cyril Hrubis chrubis@suse.cz