[LTP] [PATCH 3/9] metadata: parse.sh: Pass -v to metaparse on VERBOSE=1
Petr Vorel
pvorel@suse.cz
Fri Feb 23 15:37:55 CET 2024
> Hi Cyril,
> > Hi!
> > > +[ "$VERBOSE" ] && v="-v"
> > The build system uses just V=1 for a verbose mode so we should probably
> > be consistent...
> We actually use both, see include/mk/env_pre.mk
> ifeq ($V,1)
> VERBOSE=1
> endif
> Therefore should I use both here as well?
> [ "$VERBOSE" -o "$V" ] && v="-v"
[ "$V" ] && VERBOSE=1
...
a=$($top_builddir/metadata/metaparse $VERBOSE -Iinclude -Itestcases/kernel/syscalls/utils/ "$test")
(for global scope variable is better to use upper case)
Kind regards,
Petr
> Kind regards,
> Petr
More information about the ltp
mailing list