[LTP] [PATCH 2/2] syscalls/munmap02: Refactor the test using new LTP API

Avinesh Kumar akumar@suse.de
Wed Jan 10 10:45:52 CET 2024


On Tuesday, November 14, 2023 9:37:16 AM CET Richard Palethorpe wrote:
> Hello,
> 
> Andrea Cervesato via ltp <ltp@lists.linux.it> writes:
> > Hi!
> > 
> > munmap01 and munmap02 looks quite similar. The refactoring is good to
> > me, but maybe we can merge them into a single test using 2 different
> > test cases, where the first is mapping a certain portion of the file
> > and the second an another.
> 
> Yes, these should be merged. Otherwise the rewrite looks good.
> 

Hi,

sorry for not responding to this review earlier.
But may I request for merging these patches if the refactoring is fine. I agree 
that these both should be combined to single test, and I would like to do 
that, but maybe in the second step after upcoming release.

Thank you,
Avinesh




More information about the ltp mailing list