[LTP] [PATCH v2] sched: add sched sysctl sanity test
Cyril Hrubis
chrubis@suse.cz
Wed Jan 10 12:00:47 CET 2024
Hi!
> It looks like the second fix 079be8fc6309 ("sched/rt: Disallow writing invalid
> values to sched_rt_period_us") is not in stable, shouldn't be there?
No idea to be honest, the second fix about rejecting invalid values is a
minor fix.
> > - Fixed a few whitespaces
> > - Added second kernel commit into metadata
> nit: metadata of the git commit looks ugly, but we would need to agree on better
> solution.
Which metadata exactly? This part is after the scisors and will be cut
when the patch is applied.
> > runtest/sched | 2 +
> > testcases/kernel/sched/sysctl/.gitignore | 1 +
> > testcases/kernel/sched/sysctl/Makefile | 7 +
> > .../kernel/sched/sysctl/proc_sched_rt01.c | 122 ++++++++++++++++++
> > 4 files changed, 132 insertions(+)
> > create mode 100644 testcases/kernel/sched/sysctl/.gitignore
> > create mode 100644 testcases/kernel/sched/sysctl/Makefile
> > create mode 100644 testcases/kernel/sched/sysctl/proc_sched_rt01.c
>
> > diff --git a/runtest/sched b/runtest/sched
> > index 172fe4174..3457114f4 100644
> > --- a/runtest/sched
> > +++ b/runtest/sched
> > @@ -16,3 +16,5 @@ sched_cli_serv run_sched_cliserv.sh
> > sched_stress sched_stress.sh
>
> > autogroup01 autogroup01
> > +
> > +proc_sched_rt01
>
> This should obviously be:
> proc_sched_rt01 proc_sched_rt01
>
> And I would move it above sched_stress.sh.
Goot catch, will fix.
> The rest LGTM, thanks!
> Reviewed-by: Petr Vorel <pvorel@suse.cz>
--
Cyril Hrubis
chrubis@suse.cz
More information about the ltp
mailing list