[LTP] [PATCH 2/3] tst_fs.h: Improve tst_fibmap() doc
Petr Vorel
pvorel@suse.cz
Fri Jan 19 14:15:10 CET 2024
> Hi!
> > /*
> > - * test if FIBMAP ioctl is supported
> > + * Check if FIBMAP ioctl is supported.
> > + * Tests which use tst_fibmap() should use .needs_root = 1 to avoid EPERM.
> ^
> Maybe just:
> Tests nees to set .needs_root = 1 in order to avoid EPERM.
+1 (with "needs")
Thanks, merged!
Kind regards,
Petr
> > + * @return 0: FIBMAP is supported, 1: FIBMAP is *not* supported.
> Otherwise it looks good.
> Reviewed-by: Cyril Hrubis <chrubis@suse.cz>
More information about the ltp
mailing list