[LTP] [PATCH] lib: tst_fd: Avoid tst_brk(TCONF, ...) on older distros

Martin Doucha mdoucha@suse.cz
Wed Jan 24 15:36:24 CET 2024


On 24. 01. 24 15:21, Cyril Hrubis wrote:
> Hi!
>> Actually at least here tst_syscall() needs to be called or it fails on older
>> distros due missing ENOSYS check in raw syscall():
> 
> Ah, no we have to handle the ENOSYS ourselves as we do in the other
> cases. Sorry for not realizing that.
> 
> We likely need just:
> 
> diff --git a/lib/tst_fd.c b/lib/tst_fd.c
> index ab7de81aa..8b26ff8e5 100644
> --- a/lib/tst_fd.c
> +++ b/lib/tst_fd.c
> @@ -141,7 +141,7 @@ static void open_pidfd(struct tst_fd *fd)
>   {
>          fd->fd = syscall(__NR_pidfd_open, getpid(), 0);
>          if (fd->fd < 0)
> -               tst_brk(TBROK | TERRNO, "pidfd_open()");
> +               tst_res(TCONF | TERRNO, "pidfd_open()");
>   }

Yes, this will work. I missed the TBROK because I didn't look too 
closely at the unchanged lines in the patch...

-- 
Martin Doucha   mdoucha@suse.cz
SW Quality Engineer
SUSE LINUX, s.r.o.
CORSO IIa
Krizikova 148/34
186 00 Prague 8
Czech Republic



More information about the ltp mailing list