[LTP] [PATCH] fallocate06: Increase test loop device size to 1GB

Martin Doucha mdoucha@suse.cz
Thu Jan 25 15:12:17 CET 2024


On 25. 01. 24 15:10, Cyril Hrubis wrote:
> Hi!
>> diff --git a/testcases/kernel/syscalls/fallocate/fallocate06.c b/testcases/kernel/syscalls/fallocate/fallocate06.c
>> index 124fb7eae..83b4d88e6 100644
>> --- a/testcases/kernel/syscalls/fallocate/fallocate06.c
>> +++ b/testcases/kernel/syscalls/fallocate/fallocate06.c
>> @@ -260,6 +260,7 @@ static struct tst_test test = {
>>   	.test = run,
>>   	.tcnt = ARRAY_SIZE(testcase_list),
>>   	.needs_root = 1,
>> +	.dev_min_size = 1024,
>>   	.mount_device = 1,
>>   	.mntpoint = MNTPOINT,
>>   	.all_filesystems = 1,
> 
> Don't we need to add at least .max_runtime = 120 here as well?
> 
> Looks like I'm getting quite close to the default 30s timeout on a
> machine with a old good rotating harddisc. I did measure between 10 and
> 20s for the case that we fill the 1GB filesystem.

OK, let's add that just in case. Should I resubmit?

-- 
Martin Doucha   mdoucha@suse.cz
SW Quality Engineer
SUSE LINUX, s.r.o.
CORSO IIa
Krizikova 148/34
186 00 Prague 8
Czech Republic



More information about the ltp mailing list