[LTP] [PATCH v2 1/5] Add stat04 test

Petr Vorel pvorel@suse.cz
Wed Jul 10 12:38:51 CEST 2024


Hi Andrea,

...
> > > +static void cleanup(void)
> > > +{
> > > +	free(tmpdir);
> > nit: I know that tst_get_tmpdir() is first thing in setup(), but I would still
> > guard it with if (tmpdir) (code may change later).

> > > +
> > > +	SAFE_UNLINK(SYMBNAME);
> > nit: Ideally this would be guarded by flag that SAFE_SYMLINK(file_path,
> > symb_path) got executed.
> What if it doesn't?

Well, just one more WARN, no big deal. Just it might be misleading for a
reviewer. I see you fixed it in v3, thanks!

Kind regards,
Petr


More information about the ltp mailing list