[LTP] [PATCH v3 3/4] Add chmod08 test

Petr Vorel pvorel@suse.cz
Wed Jul 10 17:12:01 CEST 2024


Hi Andrea,

Reviewed-by: Petr Vorel <pvorel@suse.cz>

thanks a lot, merged with tiny changes.

> +++ b/testcases/kernel/syscalls/chmod/chmod08.c
> @@ -0,0 +1,45 @@
> +// SPDX-License-Identifier: GPL-2.0-or-later
> +/*
> + * Copyright (c) 2000 Silicon Graphics, Inc.  All Rights Reserved.
> + *    Author: David Fenner
> + *    Copilot: Jon Hendrickson
> + * Copyright (C) 2024 Andrea Cervesato andrea.cervesato@suse.com
very nit: <andrea.cervesato@suse.com> (missing < >). Added.
> + */
> +
> +/*\
> + * [Description]
> + *
> + * This test verifies that chmod() is working correctly on symlink()
> + * generated files.
> + */
> +
> +#include "tst_test.h"
> +
> +#define PERMS 01777
> +#define TESTFILE "myobject"
> +#define	SYMBNAME "my_symlink0"
Very nit: you mix tabs and spaces as a separator after define. Fixed.

Kind regards,
Petr


More information about the ltp mailing list