[LTP] [RFC PATCH 2/2] sched_football: Rewrite into new API

Cyril Hrubis chrubis@suse.cz
Mon Jul 15 12:38:57 CEST 2024


Hi!
> > And the main problem with our build system is not the tooling we choose,
> > but the complexity imposed by the out-of-tree build implemented in the
> > complex makefiles. As far as I can tell 99% of the problems would be
> > solved by ripping out out-of-tree support, which would remove most of
> > the code we have in there.
> 
> +1 for removal. I wonder if anybody finds a time to do that.

That is unfortunatelly a major task...

> > > But back to the reality, would it be possible to merge this even with broken
> > > dependency? I'm not sure myself.
> 
> > I will double check the code, before adding my final reviewed-by.
> 
> Thank you! It still bothers me that building sched_football does not trigger
> building a library, but at least it will work for a full build (building whole
> LTP).

It's even more subtle, there are more things to consider. The test
should be rebuild even if any of the headers it includes change, which
is not detected properly at the moment. For that to work first thing the
build system has to do is to generate a dependencies with $(CC) -MM and
then include them in the build system.

-- 
Cyril Hrubis
chrubis@suse.cz


More information about the ltp mailing list