[LTP] [RFC PATCH 2/2] sched_football: Rewrite into new API

Petr Vorel pvorel@suse.cz
Wed Jul 17 18:03:10 CEST 2024


> Hi!
> > -/* Here's the position of the ball */
> > -static int the_ball;
> > -
> > +static int ball;

> Honestly the only thing that I do not like about this is that you
> dropped the the_ from the ball, because *the* ball is *the* thing that
> we observe for the whole time.

OK, I put 'the_ball' back.

> Otherwise I do not think that the test library can interfere with the
> test in any way so we can go ahead and push this.

Thanks! I also add TODO to makefile for proper integration, removed unneeded
includes (mostly included by tst_test.h or unused) and merged!

Kind regards,
Petr



More information about the ltp mailing list