[LTP] [PATCH] cachestat: remove .min_kver from cachestat tests

Li Wang liwang@redhat.com
Fri Jul 26 09:52:40 CEST 2024


On Fri, Jul 26, 2024 at 2:52 PM Petr Vorel <pvorel@suse.cz> wrote:

> Hi Li, Andrea,
>
> > Hi!
>
> > On 7/26/24 04:44, Li Wang wrote:
> > > Removing the kernel version check (.min_kver) from the cachestat
> > > tests to allow the test to run on distributions that backport the
> > > cachestat syscall.
>
> > > With no support just skip as TCONF:
> > >    ../../../../include/lapi/mman.h:40: TCONF: syscall(451)
> __NR_cachestat not supported on your arch
>
> +1. Just for sure, tested on 6.4 based SLES 15-SP6 and it works as
> expected (TCONF)
>
> Reviewed-by: Petr Vorel <pvorel@suse.cz>
>

Pushed, thanks!


> Maybe we should document, that ideally we should try to avoid .min_kver
> unless
> really needed. It's also kind of a documentation, but kernel version can be
> specified in metadata documentation.
>

Yeah, especially new feature tests should be avoided .min_kver,
(can completely replace by support_syscallname() function in setup)
as many official distros always backport new things to customers.

But for other purposes, we still need that.


-- 
Regards,
Li Wang


More information about the ltp mailing list