[LTP] [PATCH v4 5/5] Add landlock06 test

Petr Vorel pvorel@suse.cz
Fri Jul 26 16:32:46 CEST 2024


> On Fri, Jul 26, 2024 at 03:24:40PM +0200, Petr Vorel wrote:
> > Hi Andrea,

> > Reviewed-by: Petr Vorel <pvorel@suse.cz>

> > Few notes below.

> > ...
> > > +static struct tst_test test = {
> > > +	.test_all = run,
> > > +	.setup = setup,
> > > +	.cleanup = cleanup,
> > > +	.min_kver = "6.10",
> > nit: would not be able to check the availablity via landlock ABI == 5?

> Because Landlock is available since 5.13, I guess min_kver should be set
> to the same version.

If anybody backport this, kernel version will not match. IMHO it's better to
avoid specifying version if we can detect with something else (ABI version in
this case). Also avoid kernel config reading if not needed is IMHO better.

Kind regards,
Petr


More information about the ltp mailing list