[LTP] [PATCH] mlock05: add log details about the success/failure

Filippo Storniolo fstornio@redhat.com
Mon Jul 29 17:43:30 CEST 2024


Hi!

Our test logs will be reviewed by people not familiar with the test purpose
or its implementation. These will be people who may not have the background
or time necessary to read and understand the source code.

However, improving the TST_EXP_EQ_LU() macro to print additional
information looks great and I believe it would be the better approach, as
it would also be useful for future contributions.
Do you already have something in mind for a possible implementation?
I was thinking of creating a new one that looks like this:
TST_EXP_EQ_LU_MSG() so that the test writer can add a custom message where
the test passes/fails.

Filippo Storniolo

On Wed, Jul 24, 2024 at 5:14 PM Cyril Hrubis <chrubis@suse.cz> wrote:

> Hi!
> > In some testing environments, such as those related to safety
> > critical requirements, more detailed logs are needed when
> > the executed test passes or fails.
> > This format already exists in other LTP tests, such as
> > kernel/security/kallsyms/kallsyms.c
>
> What exactly are the requirements? It would make more sense to improve
> the TST_EXP_EQ_LU() macro to print the additional information instead...
>
> --
> Cyril Hrubis
> chrubis@suse.cz
>
>


More information about the ltp mailing list