[LTP] [PATCH] Fix unlink09 test

Petr Vorel pvorel@suse.cz
Wed Jun 5 14:11:42 CEST 2024


Hi Martin,

> On 05. 06. 24 9:38, Petr Vorel wrote:
> > BTW shouldn't this test use .all_filesystems = 1 ? Or is it unlink() really VFS
> > only code? I see some specific functions in fs/*/, e.g. btrfs_unlink() or
> > ext4_unlink(), which are used for struct inode_operations unlink member.
> > Then, obviously also Andrea's check would be needed (otherwise is unlikely that
> > somebody would have TMPDIR on vfat or exfat).

> AFAICT, .all_filesystems and .needs_rofs are mutually exclusive at the
> moment.

Good point, I completely overlook .needs_rofs. That makes things clearer.

ATM we have 3 other tests in syscalls/unlink. Not sure if all are filesystem
specific (I would say yes, but not sure), but at least unlink05.c (tests
deleting with unlink()) should be tested .all_filesystems. unlink07.c and
unlink08.c test errno.

Kind regards,
Petr


More information about the ltp mailing list