[LTP] [PATCH] tst_kconfig: Avoid buffer overflow when parsing /proc/cmdline

Li Wang liwang@redhat.com
Wed Jun 19 09:33:45 CEST 2024


When the test is run with a kernel booting with many parameters, the
buffer size is often not large enough to store the complete command
line. This results in a buffer overflow and the test complains with
the following message:

  tst_kconfig.c:609: TWARN: Buffer overflowed while parsing /proc/cmdline

Signed-off-by: Li Wang <liwang@redhat.com>
---
 lib/tst_kconfig.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/tst_kconfig.c b/lib/tst_kconfig.c
index e16ca1400..be3842c2d 100644
--- a/lib/tst_kconfig.c
+++ b/lib/tst_kconfig.c
@@ -569,7 +569,7 @@ char tst_kconfig_get(const char *confname)
 
 void tst_kcmdline_parse(struct tst_kcmdline_var params[], size_t params_len)
 {
-	char buf[128], line[512];
+	char buf[512], line[512];
 	size_t b_pos = 0,l_pos =0, i;
 	int var_id = -1;
 
-- 
2.45.2



More information about the ltp mailing list