[LTP] [PATCH 1/1] libs: Remove 'libltp' prefix from libs source directories

Li Wang liwang@redhat.com
Mon Jun 24 14:52:30 CEST 2024


On Mon, Jun 24, 2024 at 8:31 PM Cyril Hrubis <chrubis@suse.cz> wrote:

> Hi!
> > > I know renaming files is not optimal. But history will be kept, when
> > > browsing with gitk or git gui.
> > >
> > > Improvement: less typing when cd to the directory.
> > >
>
> I do not have a strong opinion on this, feel free to push the change
> with my:
>
> Acked-by: Cyril Hrubis <chrubis@suse.cz>
>
> > +1 I agree with this, and I always have a question, why
> > we have additional libs/ parallel with lib/, is there any root
> > difference between them? or just a historical issue?
>
> The idea is exactly how it was described by Peter, these are usually
> libraries used only by a few tests e.g. functions to deal with swap or
> linux input, while lib/ has functions that are used by most of
> the tests with more generic functionalities.
>
> Apart from small speedup it makes things a bit easier to navigate, at
> least I think so. Or do you think that this would be better with all the
> files in a single directory?
>

Hmm, maybe yes, the limited speedup can be ignored for today's processors.
But putting lib together can make people understand LTP lib more
completely/easily.

Anyway, the patch itself looks good.
Reviewed-by: Li Wang <liwang@redhat.com>


-- 
Regards,
Li Wang


More information about the ltp mailing list