[LTP] [PATCH v2] getxattr04, 05: Change to docparse comment and typo fixes
Petr Vorel
pvorel@suse.cz
Wed Mar 6 22:48:21 CET 2024
Hi Avinesh, Shiyang,
I merged with following improvements below. Thanks!
> +++ b/testcases/kernel/syscalls/getxattr/getxattr04.c
> @@ -4,13 +4,15 @@
> * Author: Xiao Yang <yangx.jy@cn.fujitsu.com>
> */
> -/*
> +/*\
> + * [Description]
> + *
> * This is a regression test for the race between getting an existing
> * xattr and setting/removing a large xattr. This bug leads to that
> * getxattr() fails to get an existing xattr and returns ENOATTR in xfs
> * filesystem.
> *
> - * Thie bug has been fixed in:
> + * This bug has been fixed in:
> *
> * commit 5a93790d4e2df73e30c965ec6e49be82fc3ccfce
> * Author: Brian Foster <bfoster@redhat.com>
Just single line:
* 5a93790d4e2d ("xfs: remove racy hasattr check from attr ops")
> diff --git a/testcases/kernel/syscalls/getxattr/getxattr05.c b/testcases/kernel/syscalls/getxattr/getxattr05.c
> index f12e2f813..069e2b3f9 100644
> --- a/testcases/kernel/syscalls/getxattr/getxattr05.c
> +++ b/testcases/kernel/syscalls/getxattr/getxattr05.c
> @@ -4,12 +4,14 @@
> * Author: Xiao Yang <yangx.jy@cn.fujitsu.com>
> */
> -/*
> - * Description:
> - * 1) Witout a user namespace, getxattr(2) should get same data when
> - * acquiring the value of system.posix_acl_access twice.
> - * 2) With/Without mapped root UID in a user namespaces, getxattr(2) should
> - * get same data when acquiring the value of system.posix_acl_access twice.
> +/*\
> + * [Description]
> + *
> + * This test verifies that:
Here still needs to be empty line, I haven't managed to send v2 of the change
[1] which would allow to format it without empty line.
> + * - Without a user namespace, getxattr(2) should get same data when
> + * acquiring the value of system.posix_acl_access twice.
> + * - With/Without mapped root UID in a user namespaces, getxattr(2) should
> + * get same data when acquiring the value of system.posix_acl_access twice.
> *
> * This issue included by getxattr05 has been fixed in kernel:
> * '82c9a927bc5d ("getxattr: use correct xattr length")'
no quotes:
* 82c9a927bc5d ("getxattr: use correct xattr length")
+ I dared to use a 12 chars hash in "linux-git" (originally 11).
Kind regards,
Petr
[1] https://patchwork.ozlabs.org/project/ltp/list/?series=388930&state=*
More information about the ltp
mailing list