[LTP] [PATCH v1] chdir01.c: set umask to 0 within setup

[Martin Doucha]

Hi,
you're trying to fix a vfat mount quirk. We should fix that in the LTP 
library instead, e.g. by setting umask(0) and then restoring the 
original value inside safe_mount().

On 06. 03. 24 11:46, Wei Gao via ltp wrote:
> When system's default umask is 0077, this will trigger following issues:
> chdir01.c:100: TFAIL: nobody: chdir("subdir") returned unexpected value -1: EACCES (13)
> 
> Signed-off-by: Wei Gao <wegao@suse.com>
> ---
>   testcases/kernel/syscalls/chdir/chdir01.c | 11 ++++++++---
>   1 file changed, 8 insertions(+), 3 deletions(-)
> 
> diff --git a/testcases/kernel/syscalls/chdir/chdir01.c b/testcases/kernel/syscalls/chdir/chdir01.c
> index d50a8f50c..97a707199 100644
> --- a/testcases/kernel/syscalls/chdir/chdir01.c
> +++ b/testcases/kernel/syscalls/chdir/chdir01.c
> @@ -56,12 +56,15 @@ static struct test_case {
>   
>   static void setup(void)
>   {
> +	mode_t old_umask = umask(0);
> +
> +	SAFE_MKFS(tst_device->dev, tst_device->fs_type, NULL, NULL);Hi, 
> +	SAFE_MOUNT(tst_device->dev, MNTPOINT, tst_device->fs_type, 0, 0);
> +
>   	char *cwd;
>   	int fd;
>   	struct stat statbuf;
>   
> -	umask(0);
> -
>   	cwd = SAFE_GETCWD(NULL, 0);
>   	workdir = SAFE_MALLOC(strlen(cwd) + strlen(MNTPOINT) + 2);
>   	sprintf(workdir, "%s/%s", cwd, MNTPOINT);
> @@ -89,6 +92,7 @@ static void setup(void)
>   
>   	if (!ltpuser)
>   		ltpuser = SAFE_GETPWNAM(TESTUSER);
> +	umask(old_umask);
>   }
>   
>   static void check_result(const char *user, const char *name, int retval,
> @@ -146,13 +150,14 @@ static void cleanup(void)
>   {
>   	SAFE_CHDIR("..");
>   	free(workdir);
> +	SAFE_UMOUNT(MNTPOINT);
>   }
>   
>   static struct tst_test test = {
>   	.needs_root = 1,
> -	.mount_device = 1,
>   	.mntpoint = MNTPOINT,
>   	.all_filesystems = 1,
> +	.needs_device = 1,
>   	.test = run,
>   	.tcnt = ARRAY_SIZE(testcase_list),
>   	.setup = setup,

-- 
Martin Doucha   mdoucha@suse.cz
SW Quality Engineer
SUSE LINUX, s.r.o.
CORSO IIa
Krizikova 148/34
186 00 Prague 8
Czech Republic