[LTP] [PATCH] Hugetlb: Migrating libhugetlbfs test truncate_reserve_wraparound.c

[Geetika M]

On 28/11/23 4:55 pm, Petr Vorel wrote:
> Hi,
>
> Please have look at my comments at your colleague patch [1] [2], these changes
> apply a lot for your patches as well.
>
> [1] https://lore.kernel.org/ltp/20231128111024.GA364870@pevik/
> [2] https://lore.kernel.org/ltp/20231128112254.GA367506@pevik/

I will have a look at both of these and apply the changes that apply to 
this
testcase and send the next version.

> ...
>> +++ b/runtest/hugetlb
>> @@ -35,6 +35,7 @@ hugemmap29 hugemmap29
>>   hugemmap30 hugemmap30
>>   hugemmap31 hugemmap31
>>   hugemmap32 hugemmap32
>> +hugemmap38 hugemmap38
> nit: Why not hugemmap34? (your colleague used hugemmap33 for his patch [1].
We already have:

hugemmap34 : 
https://lore.kernel.org/ltp/20230913082214.8453-1-samir@linux.vnet.ibm.com/
hugemmap36 : 
https://lore.kernel.org/ltp/20230912064126.3350-1-samir@linux.vnet.ibm.com/
hugemmap35 : 
https://lore.kernel.org/all/20230908121135.245296-1-sachinpb@linux.vnet.ibm.com/
hugemmap37 : 
https://lore.kernel.org/ltp/20230929075435.72172-1-geetika@linux.ibm.com/

Hence hugemmap38!
>>   hugemmap05_1 hugemmap05 -m
>>   hugemmap05_2 hugemmap05 -s
>>   hugemmap05_3 hugemmap05 -s -m
> ...
>
> Kind regards,
> Petr

Thanks & Regards,
Geetika