[LTP] [PATCH 1/1] doc: libltpswap: Add kerneldoc

Andrea Cervesato andrea.cervesato@suse.com
Tue May 7 10:28:32 CEST 2024


Hi!

LGTM with fix

Reviewed-by: Andrea Cervesato <andrea.cervesato@suse.com>

On 4/26/24 20:25, Petr Vorel wrote:
> Hi Li,
>
>>>>    /**
>>>> - * Macro to create minimal swapfile.
>>>> + * MAKE_SMALL_SWAPFILE - create small swap file.
>>>> + *
>>>> + * Macro to create small small swap file. Size defined with
>>> MINIMAL_SWAP_SIZE_MB.
>>> "small small" sounds weird. Maybe "really small"
>
>> +1 I guess that might be one typo.
>> Otherwise looks good to me, thanks!
> Thanks a lot for catching these (on 2 places, diff below). I'm travelling for a
> few days, thus I'll leave it for others to see before merge.
>
> Kind regards,
> Petr
>
> +++ include/libswap.h
> @@ -30,7 +30,7 @@ int make_swapfile(const char *file, const int lineno,
>   /**
>    * MAKE_SMALL_SWAPFILE - create small swap file.
>    *
> - * Macro to create small small swap file. Size defined with MINIMAL_SWAP_SIZE_MB.
> + * Macro to create small swap file. Size defined with MINIMAL_SWAP_SIZE_MB.
>    *
>    * @swapfile: swap filename.
>    */
> @@ -41,7 +41,7 @@ int make_swapfile(const char *file, const int lineno,
>   /**
>    * SAFE_MAKE_SMALL_SWAPFILE - create small swap file (safe version).
>    *
> - * Macro to create small small swap file. Size defined with MINIMAL_SWAP_SIZE_MB.
> + * Macro to create small swap file. Size defined with MINIMAL_SWAP_SIZE_MB.
>    * Includes safety checks to handle potential errors.
>    *
>    * @swapfile: swap filename.




More information about the ltp mailing list