[LTP] [PATCH 1/9] KVM: Disable EBP register use in 32bit code

Petr Vorel pvorel@suse.cz
Tue May 7 16:22:04 CEST 2024


> On 06. 05. 24 21:41, Petr Vorel wrote:
> > >   ifeq ($(HOST_CPU),x86)
> > > -	GUEST_CFLAGS += -m32
> > > +	GUEST_CFLAGS += -m32 -ffixed-ebp

> > FYI this will fail on 32 bit build on clang:

> > clang: error: unknown argument: '-ffixed-ebp'

> > I don't want to block this patchset which brings important test, but it'd be
> > great to fix it.

> > Is there clang equivalent? Or is it even needed for clang?

> > Either way, we need to detect clang. I don't think simple

> > ifeq ($(CXX),clang)

> > would be enough, because cc can be alias to clang.
> Hmm, I need to fix this. I guess that configure should just check for
> -ffixed-ebp support.

Yes, that would be ideal solution which I definitely don't want to force you.

> Fortunately, clang doesn't generate code that would
> trigger stack segment fault so the workaround is only needed for GCC.

Great!

> Could you review and merge the trivial patches (4, 5, 6, 7) so that I don't
> need to resubmit everything?

Sure!

Kind regards,
Petr


More information about the ltp mailing list