[LTP] [PATCH v2] Rewrite fcnt14 test

[Li Wang]

On Thu, May 9, 2024 at 6:20 PM Petr Vorel <pvorel@suse.cz> wrote:

> Hi Andrea, Li,
>
> > Hi Andrea,
>
> ...
> > > +struct tst_results {
> > > +       int num_pass;
> > > +       int last_failed;
> > > +};
>
>
> > Well, I do not object to hiding the test outputting during
> > each run, but the disadvantage is if we deploy LTP in CI/CD
> > typically we get nothing useful on one-off failure logs.
> > (thus we have to rerun it with '-D' manually for reproduction)
>
> @Li For CI is more convenient to set LTP_ENABLE_DEBUG=1 environment
> variable.
> -D was meant for runtime testing when developing a test (faster than set
> an environment variable).
>

Oh, good to know this, thanks!



>
> I updated it in the docs (it was not mentioned there):
>
> https://linux-test-project.readthedocs.io/en/latest/developers/debugging.html


Nice.


>
> > So I can't tell if the total results are meaningful unless we get PASS
> > every run.
>
> > Or, we give more options in the runtest file for user choice?
>
> > # cat /runtest/syscalls
> > fcntl14_03  fcntl14 -n 10 -D
> > fcntl14_03_64  fcntl14_64 -n 10 -D
> > fcntl14_04  fcntl14 -n 10 -D -l
> > fcntl14_04_64  fcntl14_64 -n 10 -D -l
>
> > And, "tst_" prefix is only used by LTP common APIs, so here we shouldn't
> > abuse it.
>
> +1
>

After fixing the prefix name the patch looks good to me.


-- 
Regards,
Li Wang