[LTP] [PATCH] kvm_pagefault01: Do not write into tdp_mmu sysfile

Martin Doucha mdoucha@suse.cz
Tue May 28 10:33:28 CEST 2024


On 28. 05. 24 0:35, Petr Vorel wrote:
>> +
>> +	if (read_bool_sys_param(TDP_MMU_SYSFILE) > 0)
>> +		tst_res(TINFO, "tdp_mmu is enabled, beware of false negatives");
> 
> Wouldn't it be better to add "WARNING:" to make it more visible?
> 		tst_res(TINFO, "WARNING: tdp_mmu is enabled, beware of false negatives");
> 
> (if you agree, I can change it before merge)

I thought about it for a while and I see good reasons for both TINFO and 
TWARN. It shouldn't matter for our tests because tdp_mmu defaults to off 
on SLE-15SP4 and SLE-15SP5. If other reviewers agree, feel free to 
change it to TWARN.

-- 
Martin Doucha   mdoucha@suse.cz
SW Quality Engineer
SUSE LINUX, s.r.o.
CORSO IIa
Krizikova 148/34
186 00 Prague 8
Czech Republic



More information about the ltp mailing list