[LTP] [PATCH 1/1] select03: Fix false positive on TCONF

Martin Doucha mdoucha@suse.cz
Wed Nov 13 14:46:07 CET 2024


Hi!

On 13. 11. 24 11:59, Petr Vorel wrote:
> This fixes error on unsupported __NR__newselect:
> select_var.h:89: TCONF: syscall(-1) __NR__newselect not supported on your arch
> select03.c:90: TFAIL: Child exited with 32
> 
> Fixes: ffdd3b36cd ("syscalls: Add missing exit status check")
> Reported-by: Dominique Leuenberger <dleuenberger@suse.com>
> Signed-off-by: Petr Vorel <pvorel@suse.cz>
> ---
> Alternatively, we could revert to previous state (remove
> "!WEXITSTATUS(status)" check), if we really don't care about any other
> exit code.

As long as all errors are reported by the child through 
tst_res()/tst_brk(), we don't need to care about the exit code since 
it'll be recorded in the shared result buffer. I vote for removing the 
WEXITSTATUS() check and adding a comment above the condition that it's 
not needed.

-- 
Martin Doucha   mdoucha@suse.cz
SW Quality Engineer
SUSE LINUX, s.r.o.
CORSO IIa
Krizikova 148/34
186 00 Prague 8
Czech Republic



More information about the ltp mailing list