[LTP] [PATCH v4 1/4] Refactor regen.sh script to generate syscalls

[Li Wang]

On Wed, Oct 9, 2024 at 5:45 PM Andrea Cervesato <andrea.cervesato@suse.de>
wrote:

> From: Andrea Cervesato <andrea.cervesato@suse.com>
>
> Rename regen.sh into a more meaningful generate_syscalls.sh name, rename
> order into a more meaningful supported-syscalls.txt name and rewrite
> part of the regen.sh script code in order to execute it from anywhere in
> the filesystem, without need to be in its own folder. The new code is
> also more clear and concise, using native sh features which are
> simplifying the code.
>
> Signed-off-by: Andrea Cervesato <andrea.cervesato@suse.com>
> ---
>  configure.ac                                       |   2 +-
>  include/lapi/syscalls/generate_syscalls.sh         | 115
> ++++++++++++++++++
>  include/lapi/syscalls/regen.sh                     | 129
> ---------------------
>  .../lapi/syscalls/{order => supported-arch.txt}    |   0
>  4 files changed, 116 insertions(+), 130 deletions(-)
>
> diff --git a/configure.ac b/configure.ac
> index ebbf49e28..45f92477f 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -384,7 +384,7 @@ else
>      AC_SUBST([WITH_REALTIME_TESTSUITE],["no"])
>  fi
>
> -AC_CONFIG_COMMANDS([syscalls.h], [cd
> ${ac_top_srcdir}/include/lapi/syscalls; ./regen.sh])
> +AC_CONFIG_COMMANDS([syscalls.h], [cd
> ${ac_top_srcdir}/include/lapi/syscalls; ./generate_syscalls.sh
> ../syscalls.h])
>

You probably need to rebase this line if Zhijian's patch gets applied first.
 https://lists.linux.it/pipermail/ltp/2024-October/040574.html

Otherwise, this one looks pretty good.
Reviewed-by: Li Wang <liwang@redhat.com>

-- 
Regards,
Li Wang