[LTP] [PATCH] configure.ac: Fix temperory directory ./confXXXXXX not cleanup

[Zhijian Li (Fujitsu)]

Thanks for your review


On 14/10/2024 17:18, Petr Vorel wrote:
> Hi all,
> 
> Reviewed-by: Petr Vorel <pvorel@suse.cz>
> 
> nit: typos in subject: temperory => temporary

Good catch, I will collect Reviewed tags, Fixes tag and send v2


Thanks
Zhijian

> 
>> configure
>>   ->config.status
>>    -> create temperory directory ./confXXXXXX
>>    -> cd include/lapi/syscalls
>>    -> ./regen.sh
>>    -> cleanup ./confXXXXXX, registered in trap
> 
>> Where config.status changes the working directory, ./confXXXXXX is not
>> removed as a result.
> 
>> Signed-off-by: Li Zhijian <lizhijian@fujitsu.com>
>> ---
>>   configure.ac | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
>> diff --git a/configure.ac b/configure.ac
>> index b4ab81e265..d327974efa 100644
>> --- a/configure.ac
>> +++ b/configure.ac
>> @@ -386,7 +386,7 @@ else
>>       AC_SUBST([WITH_REALTIME_TESTSUITE],["no"])
>>   fi
> 
>> -AC_CONFIG_COMMANDS([syscalls.h], [cd ${ac_top_srcdir}/include/lapi/syscalls; ./regen.sh])
>> +AC_CONFIG_COMMANDS([syscalls.h], [cd ${ac_top_srcdir}/include/lapi/syscalls; ./regen.sh; cd - >/dev/null])
> 
> 
> I was thinking whether use "cd ${ac_top_builddir}", but because cd happens
> outside of regen.sh, "cd -" will always work and it's probably the best.
> 
> Also, I suppose this happen quite long time ago:
> 
> Fixes: a07008fbec ("configure.ac: Generate linux_syscall_headers.h")
> 
> I noticed the problem later on but never invested time to fix it. Li Zhijian,
> thanks for taking care.
> 
> Kind regards,
> Petr
> 
>>   # custom functions
>>   # NOTE: don't create custom functions for simple checks, put them into this file