[LTP] [PATCH] Remove now unsupported power management tests

Petr Vorel pvorel@suse.cz
Tue Oct 15 17:45:35 CEST 2024


Hi Cyril,

[ Cc automated-testing@lists.yoctoproject.org ]

> The sched_mc_power_savings and sched_smt_power_savings sysfs knobs
> were removed from kernel in:

> commit 8e7fbcbc22c12414bcc9dfdd683637f58fb32759
> Author: Peter Zijlstra <peterz@infradead.org>
> Date:   Mon Jan 9 11:28:35 2012 +0100

>     sched: Remove stale power aware scheduling remnants and dysfunctional knobs

> That went into kernel 3.5 and the minimal kernel version LTP currently
> supports is 3.10.

Good catch.

I wanted to be happy that whole power management testsuite is being removed
(legacy unmaintained code written in python which is not preferred language for
LTP).  But it's really just the unsupported subset. Otherwise
power_management_tests would need to be removed from scenario_groups/default.

> This has been discussed in:

> https://github.com/linux-test-project/ltp/pull/1016

> Signed-off-by: Cyril Hrubis <chrubis@suse.cz>
> ---
>  runtest/power_management_tests                |   3 -
>  runtest/power_management_tests_exclusive      |   6 -
>  testcases/kernel/power_management/.gitignore  |   1 -
>  testcases/kernel/power_management/README      |  29 ----
>  .../power_management/pm_cpu_consolidation.py  | 143 ------------------
>  .../power_management/pm_get_sched_values.c    |  36 -----
>  .../kernel/power_management/runpwtests01.sh   |  71 ---------
>  .../kernel/power_management/runpwtests02.sh   |  68 ---------
>  .../kernel/power_management/runpwtests05.sh   |  76 ----------

Deleted runpwtests05.sh was the only file which used pm_sched_domain.py
and pm_ilb_test.py.

And when these python scripts are deleted, there is still some dead
code in testcases/kernel/power_management/lib/pm_sched_mc.py which works with
sched_mc_power_savings: reset_schedmc() and set_sched_mc_power()
and with set_sched_smt_power: set_sched_smt_power() and reset_schedsmt().

Could you please delete these. With this:

Reviewed-by: Petr Vorel <pvorel@suse.cz>

Kind regards,
Petr


More information about the ltp mailing list