[LTP] [PATCH] lib: Print failure hints only once to reduce log duplication

Li Wang liwang@redhat.com
Wed Oct 30 09:45:58 CET 2024


The LTP test currently prints failure hints multiple times if a test
encounters several TFAIL or TBROK results. This leads to unnecessarily
verbose and duplicated logs.

This patch modifies the `print_failure_hints()` function to ensure that
failure hints are printed only once per test run. By setting `show_failure_hints`
to 0 after the first print, subsequent calls to `print_failure_hints()`
will not produce redundant output.

Fixes: 701212f08 ("Disable failure hints before we actually run the test")
Signed-off-by: Li Wang <liwang@redhat.com>
Cc: Cyril Hrubis <chrubis@suse.cz>
---
 lib/tst_test.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/lib/tst_test.c b/lib/tst_test.c
index d942a91f1..8db554dea 100644
--- a/lib/tst_test.c
+++ b/lib/tst_test.c
@@ -911,6 +911,8 @@ static void print_failure_hints(void)
 	print_failure_hint("musl-git", "missing musl fixes", MUSL_GIT_URL);
 	print_failure_hint("CVE", "vulnerable to CVE(s)", CVE_DB_URL);
 	print_failure_hint("known-fail", "hit by known kernel failures", NULL);
+
+	show_failure_hints = 0;
 }
 
 static void do_exit(int ret)
-- 
2.46.2



More information about the ltp mailing list