[LTP] [PATCH] cpuset_memory_testset.sh: Give SIGUSR1 handler time to run before changing target mapping node in tests 12 and 13

[Jacob Martin]

On 4/1/25 2:20 AM, Petr Vorel wrote:
> Hi all,
> 
>> Hi!
>>> Fixes: 70259d6e7
>>> Signed-off-by: Jacob Martin <jacob.martin@canonical.com>
>>> ---
>>>   .../cpuset/cpuset_memory_test/cpuset_memory_testset.sh          | 2 +-
>>>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
>>> diff --git a/testcases/kernel/controllers/cpuset/cpuset_memory_test/cpuset_memory_testset.sh b/testcases/kernel/controllers/cpuset/cpuset_memory_test/cpuset_memory_testset.sh
>>> index c1e7cea8f..04d7cc877 100755
>>> --- a/testcases/kernel/controllers/cpuset/cpuset_memory_test/cpuset_memory_testset.sh
>>> +++ b/testcases/kernel/controllers/cpuset/cpuset_memory_test/cpuset_memory_testset.sh
>>> @@ -383,7 +383,7 @@ talk2memory_test_for_case_12_13()
>>>   	sleep 1
>>>   	echo $1 > "$2/tasks"
>>>   	/bin/kill -s SIGUSR1 $1
>>> -
>>> +	sleep 1
> 
>> This is just another workaround that does not fix the real issue and
>> that is that the C child does not communicate properly with the shell
>> code. The best solution here would be to rewrite these tests into C.
>> There is not that much work the shell does and we would avoid parsing
>> files written by the C helper in the shell as well.
> 
> @Jacob FYI how looks the patchset which rewrites test6 to C:
> https://patchwork.ozlabs.org/project/ltp/list/?series=450626&state=*
> 
> Feel free to pick another test.
> 
> Kind regards,
> Petr

Thank you both for the feedback and info here. I'll work on converting 
cpuset_memory tests formerly 12 and 13 (now 11 and 12) to C.

Thanks,
Jacob