[LTP] [PATCH] move_pages04: Fix the doc to fit RST format

[Xinjian Ma (Fujitsu)]

Hi Andrea

> -----邮件原件-----
> 发件人: Andrea Cervesato <andrea.cervesato@suse.com>
> 发送时间: 2025年4月1日 19:30
> 收件人: Ma, Xinjian/马 新建 <maxj.fnst@fujitsu.com>; ltp@lists.linux.it
> 主题: Re: [LTP] [PATCH] move_pages04: Fix the doc to fit RST format
> 
> Hi!
> 
> On 4/1/25 11:29, Ma Xinjian via ltp wrote:
> > Signed-off-by: Ma Xinjian <maxj.fnst@fujitsu.com>
> > ---
> >   .../kernel/syscalls/move_pages/move_pages04.c | 28 +++++++++----------
> >   1 file changed, 14 insertions(+), 14 deletions(-)
> >
> > diff --git a/testcases/kernel/syscalls/move_pages/move_pages04.c
> > b/testcases/kernel/syscalls/move_pages/move_pages04.c
> > index e1ee733f0..3a56cdaca 100644
> > --- a/testcases/kernel/syscalls/move_pages/move_pages04.c
> > +++ b/testcases/kernel/syscalls/move_pages/move_pages04.c
> > @@ -10,21 +10,21 @@
> >    *
> >    * [Algorithm]
> >    *
> > - *      1. Pass the address of a valid memory area where no page is
> > - *         mapped yet (not read/written), the address of a valid memory
> area
> > - *         where the shared zero page is mapped (read, but not written to)
> > - *         and the address of an invalid memory area as page addresses to
> > - *         move_pages().
> > - *      2. Check if the corresponding status for "no page mapped" is set to
> > - *         -ENOENT. Note that kernels >= 4.3 [1] and < 6.12 [2] wrongly
> returned
> > - *         -EFAULT by accident.
> > - *      3. Check if the corresponding status for "shared zero page" is set to:
> > - *         -EFAULT. Note that kernels < 4.3 [1] wrongly returned -ENOENT.
> > - *      4. Check if the corresponding status for "invalid memory area" is set
> > - *         to -EFAULT.
> > + * #. Pass the address of a valid memory area where no page is
> > + *    mapped yet (not read/written), the address of a valid memory area
> > + *    where the shared zero page is mapped (read, but not written to)
> > + *    and the address of an invalid memory area as page addresses to
> > + *    move_pages().
> > + * #. Check if the corresponding status for "no page mapped" is set to
> > + *    -ENOENT. Note that kernels >= 4.3 [1] and < 6.12 [2] wrongly returned
> > + *    -EFAULT by accident.
> > + * #. Check if the corresponding status for "shared zero page" is set to:
> > + *    -EFAULT. Note that kernels < 4.3 [1] wrongly returned -ENOENT.
> > + * #. Check if the corresponding status for "invalid memory area" is set
> > + *    to -EFAULT.
> >    *
> > - *   [1] d899844e9c98 "mm: fix status code which move_pages() returns for
> zero page"
> > - *   [2] 7dff875c9436 "mm/migrate: convert add_page_for_migration()
> from follow_page() to folio_walk"
> > + * | [1] d899844e9c98 "mm: fix status code which move_pages() returns for
> zero page"
> > + * | [2] 7dff875c9436 "mm/migrate: convert add_page_for_migration() from
> follow_page() to folio_walk"
> These two lines can be removed due to the presence of Tags table. If we want
> to keep it, then we should probably leave them inside a dotted list. Please take a
> look at:

Thanks for the review. IMO, It might be better to keep these two lines. This way, users can more intuitively match the kernel commits with the description.

Best regards
Ma
> 
> https://linux-test-project.readthedocs.io/en/latest/users/test_catalog.html#mo
> ve-pages04
> 
> Kind regards,
> Andrea Cervesato