[LTP] [RFC][PATCH 0/2] Merge runtest files

[Andrea Cervesato]

Hi Petr,

this is a _huge_ topic that might affect LTP automation configurations.

It's a job that IMHO should be done, but it makes more sense to wait for 
testing suites definition in metadata, as well as a total refactoring of 
old LTP tests.

The reason of my statements is not only that runtest files should be 
removed one day, but also that known issues inside products which are 
tested, often require years of analysis of the runtest files and their 
executions. By shuffling tests around will create issues where there's 
no need due to a small logical improvement.

I think we should start to push more on testing suites definition inside 
metadata and to refactor tests as fast as possible. So we will be free 
from runtest files, leading to a more coherent structure of the tests 
organization.

- Andrea

On 4/3/25 12:19, Petr Vorel wrote:
> Hi,
>
> besides runtest/ipc, there are other small runtest files.  I know we are
> slowly working towards removing runtest files, but until it happen we
> might want to optimize (=> merge) small runtest files into others.
>
> With this change we have in the runtest files (ignoring comments):
>
> $ for i in runtest/*; do echo "$(grep -v '#' $i | wc -l): $i"; done | sort -rn
>
>
> $ wc -l runtest/* | sort -nr # not taking into account the comments
> 1823: runtest/syscalls
> 392: runtest/controllers
> 140: runtest/scsi_debug.part1
> 140: runtest/ltp-aiodio.part1
> 137: runtest/net.nfs
> ...
> 9: runtest/watchqueue
> 9: runtest/tracing
> 9: runtest/ima
> 7: runtest/dma_thread_diotest
> 7: runtest/cpuhotplug
> 6: runtest/net.ipv6_lib
> 6: runtest/input
> 6: runtest/capability
> 5: runtest/power_management_tests_exclusive
> 5: runtest/power_management_tests
> 5: runtest/kvm
> 4: runtest/net.multicast
> 3: runtest/uevent
> 3: runtest/hyperthreading
> 3: runtest/crashme
> 3: runtest/can
> 2: runtest/nptl
> 1: runtest/s390x_tests
> 1: runtest/irq
> 1: runtest/fcntl-locktests
> 0: runtest/staging
>
> I would suggest to:
>
> * move runtest/can to runtest/kernel_misc (better
> name would be kernel_drivers, but I don't want to do renames, even
> merging runtest files will disturb folks testing with LTP.
>
> * move runtest/fcntl-locktests to runtest/net.nfs.
>
> * runtest/nptl is NPTL test for pthread_cond_timedwait(), can this be
>    moved to runtest/sched? (there are other pthread_* tests). Not sure if
>    tests are relevant now.
>
> * runtest/irq Obviously we would need more IRQ tests (IMHO none even in
>    kselftest)
>
> I wonder if runtest/dma_thread_diotest. runtest/crashme,
> runtest/power_management_tests and runtest/power_management_tests_exclusive
> are still relevant or that much outdated, that it should be removed.
>
> I think vmcp_m.sh (the only one in runtest/s390x_tests) should be removed.
>
> Other should probably be kept separate.
>
> runtest/staging is expected to be often 0.
>
> Kind regards,
> Petr
>
> Petr Vorel (2):
>    runtest/ipc: Enable named pipes on non-blocking IO
>    runtest: Move ipc into syscalls
>
>   runtest/ipc      | 30 ------------------------------
>   runtest/syscalls |  9 +++++++++
>   2 files changed, 9 insertions(+), 30 deletions(-)
>   delete mode 100644 runtest/ipc
>