[LTP] [PATCH v5 1/4] ci: install dependences for patchwork-ci script
Andrea Cervesato
andrea.cervesato@suse.com
Mon Apr 14 15:00:35 CEST 2025
Hi Petr,
On 4/14/25 14:51, Petr Vorel wrote:
> Hi Andrea,
>
>> +++ b/ci/debian.sh
>> @@ -4,7 +4,7 @@
>> # workaround for missing oldstable-updates repository
>> # W: Failed to fetch http://deb.debian.org/debian/dists/oldstable-updates/main/binary-amd64/Packages
>> -grep -v oldstable-updates /etc/apt/sources.list > /tmp/sources.list && mv /tmp/sources.list /etc/apt/sources.list
>> +grep -v oldstable-updates /etc/apt/sources.list >/tmp/sources.list && mv /tmp/sources.list /etc/apt/sources.list
> Could you please drop (before merge) this unrelated change? It's not necessary
> nor related to the change.
>
>> apt update
>> @@ -23,6 +23,8 @@ pkg_minimal="
>> debhelper
>> devscripts
>> clang
>> + curl
>> + jq
>> gcc
>> git
>> iproute2
>> @@ -47,18 +49,18 @@ pkg_nonessential="
>> "
>> case "$ACTION" in
>> - minimal)
>> - echo "=== Installing only minimal dependencies ==="
>> - $install $pkg_minimal
>> - ;;
>> - remove-nonessential)
>> - echo "=== Make sure devel libraries are removed ==="
>> - $remove $pkg_nonessential
>> - ;;
>> - *)
>> - echo "=== Installing dependencies ==="
>> - $install $pkg_minimal $pkg_nonessential
>> - ;;
>> +minimal)
>> + echo "=== Installing only minimal dependencies ==="
>> + $install $pkg_minimal
>> + ;;
>> +remove-nonessential)
>> + echo "=== Make sure devel libraries are removed ==="
>> + $remove $pkg_nonessential
>> + ;;
>> +*)
>> + echo "=== Installing dependencies ==="
>> + $install $pkg_minimal $pkg_nonessential
>> + ;;
> Also this whitespace cleanup should not be part of the change.
>
> With this fixed:
> Reviewed-by: Petr Vorel <pvorel@suse.cz>
>
> Kind regards,
> Petr
Yeah, it's done automatically by the bash format tool. I'm going to
revert it.
Thanks,
Andrea
More information about the ltp
mailing list