[LTP] [PATCH 1/1] cgroup_lib.sh: Improve error messages

Li Wang liwang@redhat.com
Wed Apr 16 10:52:36 CEST 2025


On Wed, Apr 16, 2025 at 4:41 PM Petr Vorel <pvorel@suse.cz> wrote:

> Hi Li,
>
> > > +++ b/testcases/kernel/controllers/cgroup_lib.sh
> > > @@ -119,12 +119,12 @@ cgroup_require()
> > >         ret=$?
>
> > >         if [ $ret -eq 32 ]; then
> > > -               tst_brk TCONF "'tst_cgctl require' exited. Controller
> is
> > > probably not available?"
> > > +               tst_brk TCONF "'tst_cgctl require $ctrl' exited. $ctrl
> > > controller not available?"
>
>
> > s/exited/existed
>
> I understood that "exited" which was used previously was meant to be
> "exited
> with non-zero" (I can improve it this way to be more precise). Do you
> really
> think it's in TCONF related to controller existed?  I actually mean the
> opposite
> - one wants controller which does not exist due not configured in the
> kernel.
>

Ah, you're right, I was blind to read that.
Maybe I spent too much time looking at screens today:).

-- 
Regards,
Li Wang


More information about the ltp mailing list