[LTP] [PATCH v2] Add tls parameter and flag:CLONE_SETTLS cover for clone and clone3 syscall
chunfuwen
chwen@redhat.com
Mon Apr 28 17:24:04 CEST 2025
tls parameter and related flag:CLONE_SETTLS are missed in the testing,
so add them into existed test case
Signed-off-by: chunfuwen <chwen@redhat.com>
---
testcases/kernel/syscalls/clone/clone10.c | 164 ++++++++++++++++++++
testcases/kernel/syscalls/clone3/clone304.c | 164 ++++++++++++++++++++
2 files changed, 328 insertions(+)
create mode 100644 testcases/kernel/syscalls/clone/clone10.c
create mode 100644 testcases/kernel/syscalls/clone3/clone304.c
diff --git a/testcases/kernel/syscalls/clone/clone10.c b/testcases/kernel/syscalls/clone/clone10.c
new file mode 100644
index 000000000..8ef0f73cb
--- /dev/null
+++ b/testcases/kernel/syscalls/clone/clone10.c
@@ -0,0 +1,164 @@
+// SPDX-License-Identifier: GPL-2.0-or-later
+/*
+ * Copyright (c) 2025 Red Hat Inc. All Rights Reserved.
+ * Author: Chunfu Wen <chwen@redhat.com>
+ */
+
+/*\
+ * Add tls parameter and flag:CLONE_SETTLS cover for clone
+ */
+
+#define _GNU_SOURCE
+#include <stdlib.h>
+#include <stdio.h>
+#include <errno.h>
+#include <sched.h>
+#include <sys/wait.h>
+
+#include "tst_test.h"
+#include "clone_platform.h"
+#include "lapi/syscalls.h"
+#include "lapi/futex.h"
+
+#define TLS_SIZE 4096
+#define TLS_ALIGN 16
+
+static pid_t ptid, ctid;
+static void *tls_ptr;
+static void *child_stack;
+static struct user_desc *tls_desc;
+
+/* TLS variable to validate in child */
+static __thread int tls_test_var = 12345;
+
+static int test_flags[] = {
+ CLONE_SETTLS,
+ CLONE_PARENT | CLONE_SETTLS,
+ CLONE_CHILD_SETTID | CLONE_SETTLS,
+ CLONE_PARENT_SETTID | CLONE_VM | CLONE_SETTLS,
+ CLONE_THREAD | CLONE_SIGHAND | CLONE_VM | CLONE_CHILD_CLEARTID | CLONE_SETTLS | SIGCHLD,
+ CLONE_VM | CLONE_FS | CLONE_FILES | CLONE_VFORK | CLONE_SIGHAND | CLONE_SETTLS,
+};
+
+static void init_tls(void)
+{
+#if defined(__x86_64__)
+ /* x86-64: tls_ptr is the new %fs base address */
+ tls_ptr = aligned_alloc(TLS_ALIGN, TLS_SIZE);
+ if (!tls_ptr)
+ tst_brk(TBROK | TERRNO, "aligned_alloc for TLS failed");
+ memset(tls_ptr, 0, TLS_SIZE);
+
+#elif defined(__i386__)
+ /* x86 32-bit: TLS is a struct user_desc */
+ tls_desc = SAFE_MALLOC(sizeof(*tls_desc));
+ memset(tls_desc, 0, sizeof(*tls_desc));
+ tls_desc->entry_number = -1;
+ tls_desc->base_addr = (unsigned long)SAFE_MALLOC(TLS_SIZE);
+ tls_desc->limit = TLS_SIZE;
+ tls_desc->seg_32bit = 1;
+ tls_desc->contents = 0;
+ tls_desc->read_exec_only = 0;
+ tls_desc->limit_in_pages = 0;
+ tls_desc->seg_not_present = 0;
+ tls_desc->useable = 1;
+ tls_ptr = tls_desc;
+#elif defined(__aarch64__) || defined(__riscv) || defined(__powerpc64__) || defined(__s390x__) || defined(__loongarch__)
+ /*
+ * Other architectures: detect if dedicated TLS register is available.
+ * You don't manually touch TPIDR_EL0.
+ * The kernel automatically writes it into the TPIDR_EL0 register for the new thread after clone() succeeds.
+ */
+ tls_ptr = aligned_alloc(TLS_ALIGN, TLS_SIZE);
+ if (!tls_ptr)
+ tst_brk(TBROK | TERRNO, "aligned_alloc for TLS failed");
+ memset(tls_ptr, 0, TLS_SIZE);
+#else
+ tst_brk(TCONF, "This architecture does not support TLS");
+#endif
+}
+
+static void free_tls(void)
+{
+#if defined(__x86_64__)
+ free(tls_ptr);
+
+#elif defined(__i386__)
+ if (tls_desc) {
+ free((void *)(uintptr_t)tls_desc->base_addr);
+ free(tls_desc);
+ }
+
+#elif defined(__aarch64__) || defined(__powerpc64__) || defined(__s390x__)
+ free(tls_ptr);
+#endif
+}
+
+static void setup(void)
+{
+ child_stack = SAFE_MALLOC(CHILD_STACK_SIZE);
+ init_tls();
+}
+
+static void cleanup(void)
+{
+ free(child_stack);
+ free_tls();
+}
+
+static int check_child(void *arg LTP_ATTRIBUTE_UNUSED)
+{
+ if (tls_test_var == 12345)
+ tst_res(TPASS, "Child TLS variable has expected value");
+ else
+ tst_res(TFAIL, "Child TLS variable corrupted or not set");
+
+ tst_syscall(__NR_exit, 0);
+ return 0;
+}
+
+static long clone_child(int flags)
+{
+ TEST(ltp_clone7(flags, check_child, NULL, CHILD_STACK_SIZE,
+ child_stack, &ptid, tls_ptr, &ctid));
+
+ if (TST_RET == -1 && TTERRNO == ENOSYS)
+ tst_brk(TCONF, "clone parameters doesn't match");
+
+ if (TST_RET == -1)
+ tst_brk(TBROK | TTERRNO, "clone() failed");
+
+ return TST_RET;
+}
+
+static void verify_tls(unsigned int i)
+{
+ pid_t child;
+ ctid = -1;
+ struct timespec timeout = { 5 /* sec */, 0 };
+ child = SAFE_FORK();
+ if (!child) {
+ tst_syscall(__NR_getpid);
+ clone_child(test_flags[i]);
+ if (test_flags[i] & CLONE_THREAD) {
+ if (syscall(SYS_futex, &ctid, FUTEX_WAIT, -1, &timeout)) {
+ if (errno != EWOULDBLOCK || ctid == -1) {
+ tst_res(TFAIL | TERRNO,
+ "futex failed, ctid: %d", ctid);
+ exit(0);
+ }
+ }
+ }
+ exit(0);
+ }
+ sleep(1);
+ tst_reap_children();
+}
+
+static struct tst_test test = {
+ .tcnt = ARRAY_SIZE(test_flags),
+ .test = verify_tls,
+ .setup = setup,
+ .cleanup = cleanup,
+ .forks_child = 1
+};
diff --git a/testcases/kernel/syscalls/clone3/clone304.c b/testcases/kernel/syscalls/clone3/clone304.c
new file mode 100644
index 000000000..418d86134
--- /dev/null
+++ b/testcases/kernel/syscalls/clone3/clone304.c
@@ -0,0 +1,164 @@
+// SPDX-License-Identifier: GPL-2.0-or-later
+/*
+ * Copyright (c) 2025 Red Hat Inc. All Rights Reserved.
+ * Author: Chunfu Wen <chwen@redhat.com>
+ */
+
+/*\
+ * Add tls parameter and flag:CLONE_SETTLS cover for clone3
+ */
+
+#define _GNU_SOURCE
+
+#include <stdlib.h>
+#include <sys/wait.h>
+
+#include "tst_test.h"
+#include "lapi/sched.h"
+#include "lapi/pidfd.h"
+
+#define TLS_SIZE 4096
+#define TLS_ALIGN 16
+
+static int pidfd, child_tid, parent_tid;
+static struct clone_args *args;
+static void *tls_ptr;
+static struct user_desc *tls_desc;
+
+/* TLS variable to validate in child */
+static __thread int tls_test_var = 54321;
+
+static int test_flags[] = {
+ CLONE_FS | CLONE_SETTLS,
+ CLONE_NEWPID | CLONE_SETTLS,
+};
+
+static void *allocate_tls_region(void)
+{
+ void *tls_area = aligned_alloc(TLS_ALIGN, TLS_SIZE);
+ if (!tls_area) {
+ perror("aligned_alloc");
+ exit(EXIT_FAILURE);
+ }
+ memset(tls_area, 0, TLS_SIZE);
+ return tls_area;
+}
+
+static void initialize_tls(void)
+{
+#if defined(__x86_64__)
+ /* x86-64: tls_ptr is the new %fs base address */
+ tls_ptr = aligned_alloc(TLS_ALIGN, TLS_SIZE);
+ if (!tls_ptr)
+ tst_brk(TBROK | TERRNO, "aligned_alloc for TLS failed");
+ memset(tls_ptr, 0, TLS_SIZE);
+
+#elif defined(__i386__)
+ /* x86 32-bit: TLS is a struct user_desc */
+ tls_desc = SAFE_MALLOC(sizeof(*tls_desc));
+ memset(tls_desc, 0, sizeof(*tls_desc));
+ tls_desc->entry_number = -1;
+ tls_desc->base_addr = (unsigned long)SAFE_MALLOC(TLS_SIZE);
+ tls_desc->limit = TLS_SIZE;
+ tls_desc->seg_32bit = 1;
+ tls_desc->contents = 0;
+ tls_desc->read_exec_only = 0;
+ tls_desc->limit_in_pages = 0;
+ tls_desc->seg_not_present = 0;
+ tls_desc->useable = 1;
+
+ tls_ptr = tls_desc;
+#elif defined(__aarch64__) || defined(__powerpc64__) || defined(__s390x__)
+ /*
+ * Other architectures: detect if dedicated TLS register is available.
+ * You don't manually touch TPIDR_EL0.
+ * The kernel automatically writes it into the TPIDR_EL0 register for the new thread after clone() succeeds.
+ */
+ tls_ptr = aligned_alloc(TLS_ALIGN, TLS_SIZE);
+ if (!tls_ptr)
+ tst_brk(TBROK | TERRNO, "aligned_alloc for TLS failed");
+ memset(tls_ptr, 0, TLS_SIZE);
+#else
+ tst_brk(TCONF, "This architecture does not support TLS");
+#endif
+}
+
+static void free_tls(void)
+{
+#if defined(__x86_64__)
+ free(tls_ptr);
+
+#elif defined(__i386__)
+ if (tls_desc) {
+ free((void *)(uintptr_t)tls_desc->base_addr);
+ free(tls_desc);
+ }
+
+#elif defined(__aarch64__) || defined(__powerpc64__) || defined(__s390x__)
+ free(tls_ptr);
+#endif
+}
+
+static void do_child(void)
+{
+ /* Validate TLS usage */
+ if (tls_test_var == 54321) {
+ tst_res(TPASS, "Child TLS variable has expected value");
+ } else {
+ tst_res(TFAIL, "Child TLS variable corrupted or not set");
+ }
+ exit(0);
+}
+
+static void run(unsigned int n)
+{
+ int status;
+ pid_t pid;
+
+ void *tls_ptr = allocate_tls_region();
+
+ args->flags = test_flags[n];
+ args->pidfd = (uint64_t)(&pidfd);
+ args->child_tid = (uint64_t)(&child_tid);
+ args->parent_tid = (uint64_t)(&parent_tid);
+ args->stack = 0;
+ args->stack_size = 0;
+ args->tls = (uint64_t)tls_ptr;
+
+ TEST(pid = clone3(args, sizeof(*args)));
+ if (pid < 0) {
+ tst_res(TFAIL | TTERRNO, "clone3() failed (%d)", n);
+ free(tls_ptr);
+ return;
+ }
+
+ if (!pid)
+ do_child();
+
+ SAFE_WAITPID(pid, &status, __WALL);
+ free(tls_ptr);
+}
+
+static void setup(void)
+{
+ clone3_supported_by_kernel();
+ initialize_tls();
+}
+
+static void cleanup(void)
+{
+ free_tls();
+}
+
+static struct tst_test test = {
+ .tcnt = ARRAY_SIZE(test_flags),
+ .test = run,
+ .setup = setup,
+ .cleanup = cleanup,
+ .needs_root = 1,
+ .needs_checkpoints = 1,
+ .bufs = (struct tst_buffers []) {
+ {&args, .size = sizeof(*args)},
+ {},
+ }
+};
--
2.43.5
More information about the ltp
mailing list