[LTP] [PATCH v8 1/3] syscalls/modify_ldt: Add lapi/ldt.h

[Andrea Cervesato]

Hi Ricardo,

On 4/29/25 12:01, Ricardo B. Marlière wrote:
> I thought braces were not necessary for single statements blocks, it
> does not mention multi-line single statements. Checkpatch.pl does not
> say anything:
>
> $ b4 prep --check
> Checking patches using:
>    /mnt/ext/src/linux/ltp/conversions/modify_ldt/scripts/checkpatch.pl -q --terse --no-summary --mailback
>   --showfile --no-tree --ignore CONST_STRUCT,VOLATILE,SPLIT_STRING,FILE_PATH_CHANGES
> ---
> ● 23e78431927d: syscalls/modify_ldt: Add lapi/ldt.h
>    ● checkpatch.pl: include/lapi/ldt.h:1: WARNING: Improper SPDX comment style for 'include/lapi/ldt.h',
> please use '/*' instead
>    ● checkpatch.pl: include/lapi/ldt.h:1: WARNING: Missing or malformed SPDX-License-Identifier tag in li
> ne 1
> ● 26016810e17f: syscalls/modify_ldt02: Refactor into new API
>    ● checkpatch.pl: testcases/kernel/syscalls/modify_ldt/common.h:1: WARNING: Improper SPDX comment style
>   for 'testcases/kernel/syscalls/modify_ldt/common.h', please use '/*' instead
>    ● checkpatch.pl: testcases/kernel/syscalls/modify_ldt/common.h:1: WARNING: Missing or malformed SPDX-L
> icense-Identifier tag in line 1
> ● 9d33db29e43b: syscalls/modify_ldt01: Refactor into new API
> ---
> Success: 1, Warning: 4, Error: 0
 From the point of view of the tst_brk_ call, it's "one line", but the 
block itself is 2/3 lines after the condition, so we need braces.
Please fix also the warning related to the license comment. I missed 
that, we need to use:

/* SPDX-License-Identifier: GPL-2.0-or-later */

- Andrea