[LTP] [PATCH v4 2/2] modules.mk: Add FORCE_MODULES=1 to fail on error
Li Wang
liwang@redhat.com
Fri Aug 15 09:34:11 CEST 2025
Petr Vorel <pvorel@suse.cz> wrote:
> > Yes, but FORCE_MODULES=1 is still make sense, people may not like
> > to see the module's error stop the build every time.
>
> I guess you're talking about the 'make modules' exit code, right?
> NOTE: I don't expect this target would be run in production builds (e.g. rpm
> or other package creation), I want to add it to CI and use in manual debugging.
>
> With the change above we're implementing 2. I'm not sure what is the best.
> Failing on first error hides other errors, but it's easier to spot the error,
> therefore I tend to this variant.
Yes, we only need to add something (like " || exit $$? ") in the
top-level Makefile based on patch v4.
--
Regards,
Li Wang
More information about the ltp
mailing list