[LTP] [PATCH v3] flock: Add test for verifying EINTR errno

[Avinesh Kumar]

On Friday, January 31, 2025 12:01:36 PM CET Petr Vorel wrote:
> > On Monday, October 21, 2024 9:55:21 PM CET Petr Vorel wrote:
> > > Hi Avinesh, Yang Xu,
> 
> > > > Signed-off-by: Yang Xu <xuyang2018.jy@fujitsu.com>
> > > > Signed-off-by: Avinesh Kumar <akumar@suse.de>
> > > ...
> > > > --- /dev/null
> > > > +++ b/testcases/kernel/syscalls/flock/flock07.c
> > > > @@ -0,0 +1,70 @@
> > > > +// SPDX-License-Identifier: GPL-2.0-or-later
> > > > +/*
> > > > + * Copyright (c) 2024 FUJITSU LIMITED. All Rights Reserved.
> > > > + * Author: Yang Xu <xuyang2018.jy@fujitsu.com>
> > > > + * Copyright (c) 2024 Linux Test Project
> > > > + */
> > > > +
> > > > +/*\
> > > > + * [Description]
> > > > + *
> > > > + * Verify that flock(2) fails with errno EINTR when waiting to acquire a lock,
> > > > + * and the call is interrupted by a signal.
> 
> > > Avinesh, you mentioned at Yang Xu's v1 [1] that EINTR test is getting timed out
> > > randomly. I also experienced timeouts on aarch64 and ppc64le. v1 had 2 tests
> > > (EINTR and EWOULDBLOCK), you here posted only EINTR. I would expect you would
> > > put here only the other one - EWOULDBLOCK. Or am I missing something?
> > Hi Petr,
> 
> > I am sorry, I completely missed this.
> > I sent the patch for EWOULDBLOCK case now -
> > https://lore.kernel.org/ltp/20250114155013.7644-1-akumar@suse.de/T/#u
> 
> Thanks for info. I'm closing this as rejected. Please let me know if I did not
> understand you and this is a valid patch.

Hi Petr, the above v3 patch (for new test of flock/EINTR errno) is still valid.
I took out the EWOULDBLOCK test from the original patch (by Yang Xu) and
added that to flock02, you already merged that one.
So you can review flock07.c patch just for the EINTR case.

Thanks,
Avinesh

> 
> Kind regards,
> Petr
> 
> > Regards,
> > Avinesh
> 
> > > Kind regards,
> > > Petr
> 
> > > [1] https://lore.kernel.org/ltp/1934768.7Z3S40VBb9@localhost/
> 
> 
> 
> 
> 
>