[LTP] [PATCH] flock07: Initialiaze the sigaction structure

Martin Doucha mdoucha@suse.cz
Wed Feb 5 11:24:55 CET 2025


Meh, I've made a typo in the commit message (subject) and didn't 
notice... Please fix the word "Initialize" before merge.

On 05. 02. 25 11:19, Martin Doucha wrote:
> The sigaction structure for child SIGUSR1 handler was uninitialized,
> which sometimes resulted in SA_RESTART flag being enabled by accident
> and the child flock() call never returning. Make sure the sigaction
> structure is properly initialized.
> 
> Signed-off-by: Martin Doucha <mdoucha@suse.cz>
> ---
>   testcases/kernel/syscalls/flock/flock07.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/testcases/kernel/syscalls/flock/flock07.c b/testcases/kernel/syscalls/flock/flock07.c
> index 652fe3777..368147370 100644
> --- a/testcases/kernel/syscalls/flock/flock07.c
> +++ b/testcases/kernel/syscalls/flock/flock07.c
> @@ -42,7 +42,7 @@ static void cleanup(void)
>   
>   static void child_do(int fd)
>   {
> -	struct sigaction sa;
> +	struct sigaction sa = {};
>   
>   	sa.sa_handler = handler;
>   	SAFE_SIGEMPTYSET(&sa.sa_mask);


-- 
Martin Doucha   mdoucha@suse.cz
SW Quality Engineer
SUSE LINUX, s.r.o.
CORSO IIa
Krizikova 148/34
186 00 Prague 8
Czech Republic


More information about the ltp mailing list